Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/214/add-firebase-analytics #232

Merged
merged 9 commits into from
Apr 3, 2024
Merged

Feature/214/add-firebase-analytics #232

merged 9 commits into from
Apr 3, 2024

Conversation

AmirAgassi
Copy link
Member

@AmirAgassi AmirAgassi commented Apr 1, 2024 •
edited
Loading

🔍Add Firebase Analytics to track how the website is used #214

🔍 What's Included

  • Implemented Firebase Analytics to gather insights on user interactions within the website.
  • In Analytics.tsx, initialized Firebase Analytics.
  • Updated SocialIcons.tsx to log clicks on social media icons, capturing the specific platform clicked.
  • Updated Contact.section.tsx with analytics event logging for subscription button clicks, tagged with subscribe_button_click.
  • Modified Landing.tsx to track page views on component mount and scroll percentage milestones (every 5%)
    • first_visit, session_start enabled on GA and handled by default.

🗒️ Notes

  • Make sure environment variables for Firebase configuration are added in .env for testing and deployment.
  • We may want to customize our reports on GA to better represent the events collected.

📁 Files Affected:

  • src/components/Analytics.tsx
  • src/components/SocialIcons.tsx
  • src/components/sections/Contact.section.tsx
  • src/pages/Landing.tsx

image

@AmirAgassi AmirAgassi requested review from aidantrabs and juancwu April 1, 2024 23:32
@AmirAgassi AmirAgassi self-assigned this Apr 1, 2024
@AmirAgassi AmirAgassi linked an issue Apr 1, 2024 that may be closed by this pull request
[Feature] Add Firebase Analytics to track how the website is used #214
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 1, 2024
View reviewed changes
src/pages/Landing.tsx Fixed Show fixed Hide fixed
src/pages/Landing.tsx Fixed Show fixed Hide fixed
@AmirAgassi AmirAgassi requested review from SherRao and removed request for SherRao and aidantrabs April 2, 2024 00:05
@AmirAgassi AmirAgassi requested a review from aidantrabs as a code owner April 2, 2024 00:10
juancwu
juancwu reviewed Apr 2, 2024
View reviewed changes
src/utils/Analytics.tsx Outdated Show resolved Hide resolved
src/components/sections/Contact.section.tsx Outdated Show resolved Hide resolved
@juancwu
Copy link
Contributor

juancwu commented Apr 3, 2024

@AmirAgassi only thing left is merge conflicts

@juancwu
Copy link
Contributor

juancwu commented Apr 3, 2024

Also, don't know if we want to track the clicks on the navbar for each section

@AmirAgassi
Copy link
Member Author

Also, don't know if we want to track the clicks on the navbar for each section

I've implemented it under navbar_link_click to be safe, we can always filter the events out of the GA view/reports if we end up not needing it. Lol

@aidantrabs aidantrabs merged commit 71cc986 into main Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu approved these changes

@SherRao SherRao Awaiting requested review from SherRao SherRao is a code owner

@aidantrabs aidantrabs Awaiting requested review from aidantrabs aidantrabs is a code owner

Assignees

@AmirAgassi AmirAgassi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Firebase Analytics to track how the website is used
3 participants
@AmirAgassi @juancwu @aidantrabs